Skip to content

fix(prefer-screen-queries): revert "take container into account" #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gndelia
Copy link
Collaborator

@gndelia gndelia commented Jun 10, 2020

Reverts #150

Fixes #156

container is not exposed through screen - so the only way to access container is by using it in the render result.

Therefore, what we thought it was a bug in #149 is actually a valid scenario

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sort this out so quickly :)

@Belco90 Belco90 changed the title Revert "fix(prefer-screen-queries): take container into account" fix(prefer-screen-queries): revert "take container into account" Jun 11, 2020
@Belco90 Belco90 merged commit 1850851 into testing-library:master Jun 11, 2020
@Belco90
Copy link
Member

Belco90 commented Jun 11, 2020

🎉 This PR is included in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90
Copy link
Member

Belco90 commented Jun 11, 2020

@all-contributors please add @pustovalov for bug

@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @pustovalov! 🎉

@gndelia gndelia deleted the revert-150-fix-prefer-screen-queries branch June 11, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screen.container undefined
2 participants